Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dutch password_hint translation to correspond with validation #1314

Merged
merged 1 commit into from Mar 7, 2019

Conversation

2 participants
@maantje
Copy link
Contributor

maantje commented Mar 6, 2019

At the moment the Dutch translation says Minimaal 5 tekens which means your password should be at least 5 characters long. But a 5 character long password is not allowed by the validator.

I think this was a translation error from the English one where it says Must be over 5 characters. To make the Dutch translation correct the Dutch translation should be changed to Minimaal 6 tekens.

/**
 * Get a validator for an incoming registration request.
 *
 * @param  array $data
 * @return \Illuminate\Contracts\Validation\Validator
 */
protected function validator(array $data)
{
    return Validator::make($data, [
        'name' => 'required|max:255',
        'email' => 'required|email|max:255|unique:users',
        'password' => 'required|min:6',
    ]);
}
Update Dutch password_hint translation to correspond with validation …
…rule

At the moment the translation says ```Minimaal 5 tekens``` which means your password should be at least 5 characters long. But a 5 character long password is not allowed by the validator. 

I think this was a translation error from the English one where it says ```Must be over 5 characters```. To make the Dutch translation correct the Dutch translation should be changed to ```Minimaal 6 tekens```.

```
    /**
     * Get a validator for an incoming registration request.
     *
     * @param  array $data
     * @return \Illuminate\Contracts\Validation\Validator
     */
    protected function validator(array $data)
    {
        return Validator::make($data, [
            'name' => 'required|max:255',
            'email' => 'required|email|max:255|unique:users',
            'password' => 'required|min:6',
        ]);
    }
```

@ssddanbrown ssddanbrown added this to the v0.25.2 milestone Mar 7, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 7, 2019

Thanks for spotting this @maantje.
I will merge in now ready for the next patch release.

@ssddanbrown ssddanbrown merged commit 579d98a into BookStackApp:master Mar 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.