Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1306 - Allow custom name attribute in LDAP #1317

Merged
merged 3 commits into from Mar 10, 2019

Conversation

3 participants
@dfanara
Copy link
Contributor

dfanara commented Mar 9, 2019

Adds the ability to configure which attribute is mapped to the display name of the user.

@ssddanbrown ssddanbrown added this to the v0.25.2 milestone Mar 10, 2019

@ssddanbrown ssddanbrown merged commit 6d20bdc into BookStackApp:master Mar 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 10, 2019

Thanks for this @dfanara. All looked and worked great! Merged ready for the next patch release.

@craftbyte

This comment has been minimized.

Copy link

craftbyte commented Mar 12, 2019

Hey, @dfanara I had some issues while using this.

When I set the config option to displayName, nothing was being populated while if I set the config to displayname it worked. Our LDAP server is a Microsoft AD and if I do an ldapsearch from the CLI, the attribute is name with a capital N, while the code in BookStack changes that attribute to lowercase somewhere. This should either be noted in documentation or looked at (cc @ssddanbrown).

@dfanara

This comment has been minimized.

Copy link
Contributor Author

dfanara commented Mar 12, 2019

@craftbyte I've looked into your issue and I found that php-ldap converts all of the ldap attributes to lower case (http://php.net/manual/en/function.ldap-get-entries.php).

I'll submit a PR for a fix for this, but until it is released I think @ssddanbrown could add a note to the documentation.

Sorry for the confusion and thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.