Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'Create New Book' button on shelf list #1366

Merged

Conversation

2 participants
@cw1998
Copy link
Contributor

commented Apr 3, 2019

A solution for #1260 .
image

Some notes:

  • When a book is added, it is added to the top of the shelf.
  • When a book is added, you get redirected back to the shelf rather than the new book. This works for me, but may not work for the majority.
@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Great stuff, Thanks @cw1998.

I'm currently in the middle of a design update (#1153) so I'll probably wait until that's merged into master (Couple of weeks) before I review and merge this. Looks good from a quick scan of the changes though!

@cw1998 cw1998 force-pushed the cw1998:feature/create-book-button-on-shelves branch from e219d32 to 8441900 Apr 15, 2019

@cw1998

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

Hi @ssddanbrown , I've updated this PR after the merge of the 2019 design. I went for a blue "Create New Book" button on an empty shelf rather than red (based on seeing orange text for adding a new chapter to an empty book) - hopefully this is correct.

@ssddanbrown ssddanbrown merged commit 8441900 into BookStackApp:master Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Thanks again for this @cw1998.

All looked pretty good. Made a few logical changes, in addition to aligning some existing wording, in 7f3f6e6:

  • I changed the addition of books to be an append instead of a prepend. I think this is what users will generally expect, and aligns with the analogy where you'd generally add a new book to the end of a shelf.
  • As you mentioned in your original post, I updated the post-create redirect to navigate to the book since I think most people will go on to create book content and this behaviour aligns with the existing book creation process.

All merged, ready for the next release!

@cw1998

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

Awesome, thanks. I agree with the changes mentioned and they all make sense. I'll keep wording in mind next time too.
Looking forward to seeing the new design in a release!

@cw1998 cw1998 deleted the cw1998:feature/create-book-button-on-shelves branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.