Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dots with something else on user create and edit screens #1392

Merged
merged 1 commit into from Apr 20, 2019

Conversation

2 participants
@cw1998
Copy link
Contributor

commented Apr 15, 2019

Fix for #1325
Dot notation handling in laravel means it was looking for the existence of a value in the wrong place.
Eg, if the role name was a.role.name it would look in roles['a']['role']['name'] instead of roles['a.role.name']

I couldn't find anywhere where the name of the role is used in setting roles (they are set with IDs), so changing the dots in the form elements name attribute to something else seems to have fixed this without any unintended side effects.

Could be an issue if someone had a role called a.role and a second role called aDOTrole, but I can't see this being the case for too many users.

Edit: I should note that the display name of the role isn't changed, so it will still appear in the form with dots.

@ssddanbrown ssddanbrown added this to the v0.26.0 milestone Apr 20, 2019

@ssddanbrown ssddanbrown merged commit 29f17fd into BookStackApp:master Apr 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Thanks again @cw1998,
Now merged for next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.