Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image management rewrite #1410

Merged
merged 6 commits into from May 4, 2019

Conversation

1 participant
@ssddanbrown
Copy link
Member

commented Apr 27, 2019

Not really happy with the current image management in BookStack.
This is a planned revamp of how images are handled to make things more streamlined and secure.

The plan is to remove the use of an image manager for user, system & cover images so you just select an image directly for these items.

Want to get this done for the redesign release.

--

Will address #1128 and #1307.

ssddanbrown added some commits Apr 21, 2019

ssddanbrown added some commits May 4, 2019

Change image-selector to not use manager
- Now changes the images directly for user, system & cover.
- Extra permission checks added to edit & delete actions.
Updated existing image tests to reflect changes
- Also added some new tests

@ssddanbrown ssddanbrown merged commit 15786e2 into master May 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssddanbrown ssddanbrown deleted the image_management_rewrite branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.