Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide permissions table unless custom permissions are enabled #1505

Conversation

@timoschwarzer
Copy link
Contributor

commented Jun 23, 2019

I just spent too much time figuring out why my custom permissions were not working. Turned out I didn't enable them.

This PR hides the permissions table unless you enable custom permissions. That should save some time and frustration for users who apparently cannot read (like me 馃槃).

hide-permissions-table

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Neatly implemented, thanks @timoschwarzer.

Eventually I want to change the permissions system to be sensible so you selectively add roles to permit/deny but that is on the roadmap for the future, as this is a nice UX improvement until then.

Will merge for the next feature release.

@ssddanbrown ssddanbrown merged commit 52b4c81 into BookStackApp:master Jun 25, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can鈥檛 perform that action at this time.