Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'interaction_required' response for azure #1889

Merged
merged 1 commit into from Mar 6, 2020

Conversation

@ch0wm3in
Copy link
Contributor

ch0wm3in commented Feb 12, 2020

Azure Conditional Access policy 2FA returns 'interaction_required' 400 response and therefor breaks authentication when forced to use 2FA.
SocialiteProviders/Providers#208

Azure Conditional Access policy 2FA returns 'interaction_required' 400 response SocialiteProviders/Providers#208
@MikeyMJCO

This comment has been minimized.

Copy link
Contributor

MikeyMJCO commented Feb 18, 2020

In cases where IP based conditional access MFA configurations are used in Azure AD this does indeed fix the issue. Tested on current beta.

@ssddanbrown ssddanbrown added this to the v0.28.3 milestone Mar 6, 2020
@ssddanbrown ssddanbrown merged commit 30db8af into BookStackApp:master Mar 6, 2020
3 checks passed
3 checks passed
build (7.2)
Details
build (7.3)
Details
codeclimate All good!
Details
@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 6, 2020

Thank you for this @ch0wm3in and thanks for testing it @MikeyMJCO.
Tested on my dev instance, which did not have this issue, and did not cause any side-effects there (Thinking of existing users), so now merged to be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.