New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Books page as application home page #830

Merged
merged 6 commits into from May 20, 2018

Conversation

3 participants
@Abijeet
Member

Abijeet commented May 10, 2018

Closes #615

Abijeet added some commits May 9, 2018

Added an option to set books as the default homepage.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
Added test cases.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>

@Abijeet Abijeet changed the title from [WIP] - Books page as application home page to Books page as application home page May 12, 2018

Added the book view toggle option on the homepage.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
@Abijeet

This comment has been minimized.

Member

Abijeet commented May 12, 2018

@ssddanbrown - Ready for review.

Let me know if you'd like me to make any changes in the code.

Few items tested,

  1. Setting the books page as homepage override the custom homepage option.
  2. Book view toggle on home page works properly.
  3. Removing the book homepage option reverts back to the previous home page.

@Abijeet Abijeet requested a review from ssddanbrown May 12, 2018

@ssddanbrown ssddanbrown referenced this pull request May 12, 2018

Closed

default books page #836

Abijeet added some commits May 12, 2018

removed some added CSS as it was causing unintended sideffects.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
Changed the location of the "view-toggle" to be under the books views.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
@Abijeet

This comment has been minimized.

Member

Abijeet commented May 12, 2018

Made a couple of minor adjustments based on some of the issues I found.

@mendiromania

This comment has been minimized.

mendiromania commented May 16, 2018

Great work as always Abijeet!

@ssddanbrown ssddanbrown merged commit 28823c4 into master May 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented May 20, 2018

Thanks @Abijeet, All looked great and functioned well.

I done a little view clear-up so we only have layout, base templates in the root of the views folder and extracted the home-sidebar into its own view since it was used in multiple files.

Thanks again, I know many people will be happy with this feature.

@ssddanbrown ssddanbrown deleted the feature/615 branch May 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment