New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing/Image Managment Update #837

Merged
merged 3 commits into from May 27, 2018

Conversation

3 participants
@ssddanbrown
Member

ssddanbrown commented May 13, 2018

Related to #770

This pull request was originally to add image revisions. Due to complexity and custom handling involved in doing that instead drawings now create upon update as this meets the need of the original issue.

To handle old images a new image-cleanup system has been added as both a command and a new maintenance option within settings.

Other general fixes and improvements are included to the image manager.

Started work on drawing revisions
Improved sidebar and selection styling of image manager.
Allowed image manager imageType to be changed on open.
Created models for image revisions.
Drawings now generate revisions, not replace
Updated drawing update test to accomodate.
Image deletion system now takes revisions into account.
* @param string $path
* @return bool
*/
protected function destroyImagesFromPath(string $path)

This comment has been minimized.

@Abijeet

Abijeet May 14, 2018

Member

Maybe we can also use return types? So bool here for example?

This comment has been minimized.

@ssddanbrown

ssddanbrown May 14, 2018

Member

Good idea, Will start using those when I remember. Thought they were a php7.1 feature but just double checked, all good to use!

@mendiromania

This comment has been minimized.

mendiromania commented May 16, 2018

Add configurable system limit of revisions to keep.

very useful, just yesterday I was worried about how big my database could get

@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented May 19, 2018

Coming across a lot of awkward edge cases that will mean a lot of custom handling for drawings/revisions.

Am now thinking it will be better overall to create images on drawing save instead of update which would cover the original issue and then build better tools for admins to clean-up & delete images in the system.

@ssddanbrown ssddanbrown merged commit 6cdb943 into master May 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssddanbrown ssddanbrown deleted the drawing_revisions branch May 27, 2018

@ssddanbrown ssddanbrown restored the drawing_revisions branch May 27, 2018

@ssddanbrown ssddanbrown changed the title from Image Revisions to Drawing/Image Managment Update May 27, 2018

@ssddanbrown ssddanbrown referenced this pull request May 27, 2018

Closed

Implement uploaded image versioning & deletion #770

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment