New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add everything needed to use discord as social login provider #904

Merged
merged 1 commit into from Jul 29, 2018

Conversation

2 participants
@lommes
Contributor

lommes commented Jun 28, 2018

  • Go to https://discordapp.com/developers/applications/me
  • Create new app
  • Choose app name which will be shown to the user during login/registration
  • Add http(s)://yourbookstackurl/login/service/discord/callback as redirect
  • create app
  • add Client ID as value of DISCORD_APP_ID to .env
  • add Client Secret as value of DISCORD_APP_SECRET to .env
@lommes

This comment has been minimized.

Contributor

lommes commented Jun 28, 2018

This implements #903

@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented Jul 1, 2018

Thanks @lommes, Will review and merge shortly.

On another note, Would you like to be an official BookStack member? I appreciate the effort you voluntarily provide around here so thought it might be good to make you official here on the BookStack GitHub org. You'll have abilities to manage issues and directly update code if required (Although I would ask anything fairly large to made as a reviewed pull request first). Nothing further would be expected of you, just remain polite and friendly as you currently do anyway.

@lommes

This comment has been minimized.

Contributor

lommes commented Jul 2, 2018

@ssddanbrown Sure, feel free to add me to the organization! I feel kind of honored :)

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.23.0 milestone Jul 15, 2018

@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented Jul 29, 2018

Tested, Works as expected, Thanks again @lommes, Will merge in now

@ssddanbrown ssddanbrown merged commit c83a51f into BookStackApp:master Jul 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment