New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with code not wrapping on revision page. #906

Merged
merged 1 commit into from Jul 1, 2018

Conversation

2 participants
@Abijeet
Member

Abijeet commented Jun 30, 2018

Closes #888

See image below,

image

Also tested PDF export and HTML export. The same CSS are applied to the pre code section but Dompdf does not seem to support white-space: pre-wrap whereas wkhtmltopdf does.

Signed-off-by: Abijeet abijeetpatro@gmail.com

Fixes issue with code not wrapping on revision page.
Closes #888

Signed-off-by: Abijeet <abijeetpatro@gmail.com>

@Abijeet Abijeet added the Bug label Jun 30, 2018

@Abijeet Abijeet added this to the BookStack Beta v0.23.0 milestone Jun 30, 2018

@Abijeet Abijeet self-assigned this Jun 30, 2018

@Abijeet Abijeet requested a review from ssddanbrown Jun 30, 2018

@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented Jul 1, 2018

Awesome, Works well, Thanks @Abijeet for the fix

@ssddanbrown ssddanbrown merged commit 9da600c into master Jul 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssddanbrown ssddanbrown deleted the bug/revision-wrap branch Jul 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment