New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Arabic language #945

Merged
merged 17 commits into from Sep 22, 2018

Conversation

2 participants
@kmoj86
Contributor

kmoj86 commented Aug 3, 2018

  • translated the application into Arabic.
  • added Arabic language to the drop-down list so users can choose it.
  • added Arabic language to locales.

hope this will help more people to use this application 馃槂

@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented Aug 12, 2018

Thank you @kmoj86 for the work you put into this. A couple of questions:

  1. Does everything generally work okay? From my understanding Arabic is a right-to-left language so I would have expected more work to be required to support such a language.
  2. Is it okay if I squash this before merging? Just to reduce the amount of commits that will be merged for a cleaner history. Will still show as yourself being the author.
@kmoj86

This comment has been minimized.

Contributor

kmoj86 commented Aug 12, 2018

@ssddanbrown

hello dan,

  • yes, everything works ok. but it's not the ideal way to view the application in Arabic. for best results, the CSS and text editor need to be configured for RTL. CSS only needs to be mirrored for the most part, the text editor on the other hand has to be reconfigured to handle RTL languages (Froala's WYSIWYG editor as an example).
    But nothing that renders the app unusable. I've already tested it and found no issues with it.
    That being said, this is a step forward in supporting Arabic language by translating the user interface, so anyone who doesn't speak a second language can use the application. and if one day a more experienced contributor comes to add RTL support for a better user experience, then the translation will already be here for them to use.
    In short: yes, everything is mostly ok 馃槃

  • sure thing! you can squash this for a cleaner history.
    this is my first pull request and I've been working on the translation on 2 different PCs, so sorry for the mess.

@ssddanbrown ssddanbrown referenced this pull request Aug 19, 2018

Closed

RTL support #963

@ssddanbrown ssddanbrown merged commit a686236 into BookStackApp:master Sep 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented Sep 22, 2018

Thanks again for this, Will be in the next release. My notes on RTL support here: #939 (comment)

Didn't squash the commits in the end (Didn't know how to git-squash properly with an active merge conflict 馃槅 )

@kmoj86

This comment has been minimized.

Contributor

kmoj86 commented Sep 22, 2018

@ssddanbrown
Great! thanks for all your work!
I tried to add rtl support myself by adding directionality plugin for TinyMCE, but for some reason it just didn't work for me. so this is really great news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment