Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add language hints for code blocks #1252

Closed
wants to merge 2 commits into from

Conversation

esanhueza
Copy link
Contributor

@esanhueza esanhueza commented Oct 4, 2021

Solves #1140

2021-10-03_21-17-14.mp4

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@Komediruzecki
Copy link
Contributor

Hi,

thanks for the PR, can you make the selected item color better visible in the dark theme?

@esanhueza
Copy link
Contributor Author

I added a new commit to improve the contrast of the selected hint
image
I decided to use the same style applied when the mouse hover on elements in the menu.

here is how it looked before
image

@Komediruzecki let me know what you think

@Rokt33r
Copy link
Member

Rokt33r commented Oct 18, 2021

@esanhueza The pr looks good but I found an issue. Is there any intended way to skip choosing a language mode?

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rokt33r
Copy link
Member

Rokt33r commented Nov 23, 2021

Closed this because of lack of activity. You can always reopen this pr when you can resolve the change requests

@Rokt33r Rokt33r closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants