Skip to content

scroll to bottom if another pane scrolled #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hzhangxyz wants to merge 2 commits into from
Closed

scroll to bottom if another pane scrolled #2562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f8a6fb
scroll to bottom if another pane scrolled
hzhangxyz Oct 31, 2018
85468fb
Merge remote-tracking branch 'boostnote/master' into scroll
hzhangxyz Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions browser/components/MarkdownSplitEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,24 +32,26 @@ class MarkdownSplitEditor extends React.Component {
handleScroll (e) {
if (!this.props.config.preview.scrollSync) return

const previewDoc = _.get(this, 'refs.preview.refs.root.contentWindow.document')
const previewDoc = _.get(this, 'refs.preview.refs.root.contentWindow.document.body')
const codeDoc = _.get(this, 'refs.code.editor.doc')
let srcTop, srcHeight, targetTop, targetHeight

if (this.userScroll) {
if (e.doc) {
srcTop = _.get(e, 'doc.scrollTop')
srcHeight = _.get(e, 'doc.height')
targetTop = _.get(previewDoc, 'body.scrollTop')
targetHeight = _.get(previewDoc, 'body.scrollHeight')
srcTop = _.get(codeDoc, 'scrollTop')
srcHeight = _.get(codeDoc, 'height')
targetTop = _.get(previewDoc, 'scrollTop')
targetHeight = _.get(previewDoc, 'scrollHeight')
} else {
srcTop = _.get(previewDoc, 'body.scrollTop')
srcHeight = _.get(previewDoc, 'body.scrollHeight')
srcTop = _.get(previewDoc, 'scrollTop')
srcHeight = _.get(previewDoc, 'scrollHeight')
targetTop = _.get(codeDoc, 'scrollTop')
targetHeight = _.get(codeDoc, 'height')
}

const distance = (targetHeight * srcTop / srcHeight) - targetTop
const clientHeight = _.get(previewDoc, 'clientHeight')
const distance = ((targetHeight - clientHeight) * srcTop /
(srcHeight - clientHeight)) - targetTop
const framerate = 1000 / 60
const frames = 20
const refractory = frames * framerate
Expand All @@ -63,7 +65,7 @@ class MarkdownSplitEditor extends React.Component {
scrollPos = time < 0.5
? 2 * time * time // ease in
: -1 + (4 - 2 * time) * time // ease out
if (e.doc) _.set(previewDoc, 'body.scrollTop', targetTop + scrollPos * distance)
if (e.doc) _.set(previewDoc, 'scrollTop', targetTop + scrollPos * distance)
else _.get(this, 'refs.code.editor').scrollTo(0, targetTop + scrollPos * distance)
if (frame >= frames) {
clearInterval(timer)
Expand Down