Skip to content

Conversation

@Paalon
Copy link
Contributor

@Paalon Paalon commented Nov 7, 2018

It updates KaTeX from v0.9.0 to v0.10.0. Many new features and bug fixes are included.
https://github.com/Khan/KaTeX/blob/master/CHANGELOG.md

@Paalon
Copy link
Contributor Author

Paalon commented Nov 7, 2018

What is this test? Can I overwrite and update them? I think KaTeX changes the expression intentionally.

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 7, 2018

@Paalon you can run the following command to detect the error:

yarn run test

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 7, 2018
@hzhangxyz
Copy link

I have already commited a similar pull request one month ago. but it is still "in review".

If this this pull request will be merged into master branch successfully, Please consider merging this commit(b1dbd0a) to enable global macro in katex.

I am too lazy to keep updating file tests/lib/snapshots/markdown-test.js.snap.

@Paalon
Copy link
Contributor Author

Paalon commented Nov 9, 2018

Fixed the conflict.

@omnomz
Copy link

omnomz commented Apr 7, 2019

Hi guys, will this PR ever be merged to update KaTeX to v0.10.0?

@ZeroX-DG ZeroX-DG mentioned this pull request May 10, 2019
@Rokt33r
Copy link
Member

Rokt33r commented May 29, 2019

@Paalon Could you fix the conflicts? I'll merge this as soon as you fix the conflicts!

@Rokt33r Rokt33r self-requested a review May 29, 2019 13:59
@Rokt33r
Copy link
Member

Rokt33r commented Jun 3, 2019

Resolved by #2998.

@Rokt33r Rokt33r closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants