Skip to content

Added warning popup when boostnote directory is not found & added emoji color for linux #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rvbcldud wants to merge 2 commits into from
Closed

Added warning popup when boostnote directory is not found & added emoji color for linux #3082

rvbcldud wants to merge 2 commits into from

Conversation

@rvbcldud
Copy link

@rvbcldud rvbcldud commented Jun 16, 2019 •
edited
Loading

Description

The code for issue #3073 I contributed warns the user that the boostnote directory is not being found

2 Cases

  1. When adding to disconnected boostnote directory
    boostnotefix
  2. When attempting to create a new note
    boostnotefix2

The code for issue #3061 I contributed adds in a module to allow linux users to see emojis in their proper form (in color)
boostnoteemojiix2

Issue fixed

#3073
#3061

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@rvbcldud rvbcldud changed the title Added warning popup when boostnote directory is not found Added warning popup when boostnote directory is not found & added emoji color for linux Jun 16, 2019
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 24, 2019
ZeroX-DG
ZeroX-DG requested changes Jun 28, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, you committed the node_modules folder. Please remove it from the PR.

@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. awaiting review ❇️ Pull request is awaiting a review. and removed awaiting review ❇️ Pull request is awaiting a review. needs extra review 🔎 Pull request requires review from an additional reviewer. labels Jul 20, 2019
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 2, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Mar 7, 2020

@rvbcldud ping

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Mar 21, 2020

@rvbcldud ping 2

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Apr 6, 2020

Closed due to inactivity

@ZeroX-DG ZeroX-DG closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG requested changes

Assignees

No one assigned

Labels

awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rvbcldud @ZeroX-DG