Skip to content

keep html entities in code block #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
enyaxu wants to merge 1 commit into from
Closed

keep html entities in code block #3085

enyaxu wants to merge 1 commit into from

Conversation

@enyaxu
Copy link
Contributor

@enyaxu enyaxu commented Jun 18, 2019

Description

keep html entities in code block

Issue fixed

#2931
捕获

Type of changes

  • ✅ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ✅ My code follows the project code style
  • ✅ I have written test for my code and it has been tested
  • ✅ All existing tests have been passed
  • ✅ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 24, 2019
ZeroX-DG
ZeroX-DG reviewed Jun 28, 2019
View reviewed changes
browser/lib/htmlTextHelper.js
['#63', '\\?'],
['#36', '\\$']
['#36', '\\$'],
['amp', '&']
Copy link
Member

@ZeroX-DG ZeroX-DG Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you changed this file? Is the order of the entities matter?

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 28, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Sep 14, 2019

@enyaxu ping

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jan 31, 2020

@enyaxu ping 2

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Feb 12, 2020

@enyaxu ping 3

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Mar 7, 2020

Close due to inactivity

@ZeroX-DG ZeroX-DG closed this Mar 7, 2020
juliankoehn added a commit to juliankoehn/Boostnote that referenced this pull request Aug 19, 2020
@juliankoehn
fixes BoostIO#2931 BoostIO#3085
2a02133
@juliankoehn juliankoehn mentioned this pull request Aug 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG left review comments

Assignees

No one assigned

Labels

awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enyaxu @ZeroX-DG