Skip to content

Conversation

@AWolf81
Copy link
Contributor

@AWolf81 AWolf81 commented Feb 12, 2020

Description

During PR #3002 I've noticed that Travis failed because of linting errors. With this PR I'd like to fix that problem and use prettier-standard.

Prettier by itself is not customizable. That's why I've used Standardx in the PR #2992 that was planned to add code formatting.

Not sure what's the best way to proceed. I'm also not sure when Prettier was merged to master but I think the current setup is a bit confusing and the Standardx setup is easier to understand.

I think both will work - just the other PR needs to be updated. Please let me know how to proceed if we take this one we can close the other PR.
If the other is preferred I should update it and check linting.

There were also two prettier config files that I have combined into one. I removed trailing comma rule from .prettierrc as standard.js is with-out trailing comma.

Most changes are adding space before parens to fix the space-before-parens lint issue.

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 13, 2020
@AWolf81
Copy link
Contributor Author

AWolf81 commented Feb 15, 2020

OK, I think we can close this. It was a mistake from me with space-before-parens rule. Removed the spaces with yarn fix and everything is fine.

I thought the space is required but it is not on master, so the we don't have that space.

Just not sure why format on save is not working for me.

@AWolf81 AWolf81 closed this Feb 15, 2020
@AWolf81 AWolf81 deleted the fix-prettier-setup branch February 15, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants