New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept: Feature checkbox styling #1011

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@yashha
Copy link

yashha commented Oct 24, 2017

@BoostnoteBot

This comment has been minimized.

Copy link
Collaborator

BoostnoteBot commented Oct 24, 2017

Please make sure to be pasted screenshots of all your changes.

@kazup01

This comment has been minimized.

Copy link
Member

kazup01 commented Oct 25, 2017

Hi @yashha , thanks for your suggestion and good for proof on concept.
How about this image?
todo-image

@yashha

This comment has been minimized.

Copy link

yashha commented Oct 25, 2017

Nice, I like your design.
But first we have make it much faster. At the moment it is not really userfriendly to check the item.

@kazup01

This comment has been minimized.

Copy link
Member

kazup01 commented Oct 25, 2017

Thanks for your feedback! I got it. How about like this?
howabout

@MakisH

This comment has been minimized.

Copy link

MakisH commented Nov 2, 2017

I like the proposed design! Would it be super difficult to also get e.g. a bright green (or red, or configurable even through the config file) filling for the unfilled checkbox circles? :-D

@kazup01

This comment has been minimized.

Copy link
Member

kazup01 commented Nov 3, 2017

Hi @MakisH , thank you for your feedback! Could you attach the example image?

@MakisH

This comment has been minimized.

Copy link

MakisH commented Nov 6, 2017

@kazup01 this is what I mean:

32003455-0b4959d4-b9da-11e7-884f-3cfef2df88c6

This is only the idea, though. I am sure it can be improved!

@yashha

This comment has been minimized.

Copy link

yashha commented Nov 6, 2017

So any idea how to force an update of the preview?

@kazup01

This comment has been minimized.

Copy link
Member

kazup01 commented Nov 7, 2017

I understand. Thank you :) @MakisH

@kazup01

This comment has been minimized.

Copy link
Member

kazup01 commented Dec 4, 2017

Since I merged #1194, close this pull request.
This suggestion became very helpful and excited for our team :) Thanks again @yashha !

@kazup01 kazup01 closed this Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment