New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editor rulers #1709

Merged
merged 7 commits into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@rayou
Copy link
Contributor

rayou commented Mar 21, 2018

Feature requested in #1645

Rulers is disabled by default.

I will add unit tests once @nlopin adds jest package into his commits.

mar-21-2018 22-40-51
Note: Ruler 120 was hidden due to small viewport.

@@ -57,6 +57,10 @@
opacity: 1 !important;
pointer-events: auto !important;
}
.CodeMirror-ruler {
border-left-color: rgba(142, 142, 142, 0.5);
mix-blend-mode: difference;

This comment has been minimized.

@rayou

rayou Mar 21, 2018

Contributor

overwrite the default CodeMirror Ruler color.

The default ruler color is #ccc which is too bright in dark themes, so I made this tweak to ensure the ruler fits all kind of themes.

@Rokt33r Rokt33r merged commit b766b08 into BoostIO:master Mar 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pyriand3r pushed a commit to pyriand3r/Boostnote that referenced this pull request Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment