Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1001 Back button Feature #2179

Merged
merged 41 commits into from Jan 23, 2019

Conversation

Projects
None yet
6 participants
@SubtleParesh
Copy link
Contributor

commented Jul 4, 2018

Back Button #1001
A feature to show all the history of notes is also added please review and suggest changes
Currently work in progress
back_button1_800

SubtleParesh added some commits Jun 24, 2018

back_button_working
simple working no logical errors
optimize backStack
jump note by hash
Reposition buttons
RePostioning Buttons and optimazations
Reposition buttons
RePostioning Buttons and optimazations
@Rokt33r

This comment has been minimized.

Copy link
Member

commented Jul 17, 2018

@SubtleParesh Could you fix the conflicts and lint errors from the ci?

SubtleParesh added some commits Jul 17, 2018

@mbarczak

This comment has been minimized.

Copy link

commented Aug 21, 2018

Hi, just throwing my 3 cents here : I think that the history menu could be very useful and not confusing, if it’s exposed properly to the end user. An example of good implementation could be back/forward feature from Thunderbird :
back_forward_demo
So the main functionality is going back/forward, and if anyone requires deeper control , can use the “history menu” available as a pull down menu glued to the back/forward button. @SubtleParesh worked hard on this feature, and It would be a waste to get rid of the “history menu” feature, especially if most of it is already coded ;)

@daiyam

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2018

Hi, I was checking this feature which looks good but I found an issue: when navigating, it's saving a note even if I was just seeing.

About the history menu, as it is, the navigation buttons are good for me. But maybe for other people, a drop down menu can be added between the 2 arrows. In the menu, the current note can be marked as active.

@SubtleParesh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2018

Thank you for your reply @mbarczak and @daiyam,
@daiyam you say the note is saved even when navigating, but most of the times we just see the note and do not edit it and maybe i can add some kind of timer so that if 3+ sec viewed then it will be added to the history. And yes the menu item should be surely marked as active
As @mbarczak has asked should we keep the history menu (and yes it needs some edits)?

@daiyam

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2018

@SubtleParesh A note shouldn't be marked as updated when we only view it.

@SubtleParesh

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2018

Made some changes ... I am not able to get dailyam
I dont think the note being edited or not .... has any relation with history .... though i would like to make any changes required....
Some changes i have made and i have highlighted the active note
Changes also made for forward and backward buttons thanks to @Rokt33r for help
screenshot from 2018-09-15 11-58-11

@daiyam

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2018

@SubtleParesh, the history is being hiding by the preview (maybe due to some changes in the master)

Yes, I agree whatever we edit or preview a note, that note should be added to the history.
But you should save a note only when we are editing it.

Here a part of the problematic code:

if (back.past.length > 7) {
  back.past.splice(0, 1)
  this.setState({
    backStack: back
  }, () => {
    this.save()
  })
}

It should just be:

if (back.past.length > 7) {
  back.past.splice(0, 1)
  this.setState({
    backStack: back
  })
}
@SubtleParesh

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2018

Yes..... now I get it... Thank you..... really appreciate your guidance.... especially to @daiyam and @Rokt33r
Will make changes instantly

@daiyam

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

@SubtleParesh thanks

The history menu seems to have problems with notes with the same title (only show one) and notes without title.
The next button is not disabled when reading the lastest note.

@Rokt33r

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

@SubtleParesh I'm sorry for being late to response. Could you fix the conflicts again? I'm going to merge this in this week.

@sv3ndk

This comment has been minimized.

Copy link

commented Dec 20, 2018

@SubtleParesh, are you still working on this one ? Looks like a great feature!

SubtleParesh added some commits Jan 14, 2019

Merge pull request #2 from BoostIO/master
merge master/Boostnote
@SubtleParesh

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

@Rokt33r, conflicts are fixed if your could merge it. sorry for the delay

@Rokt33r

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

@SubtleParesh Awesome! I'll review in this week. Hang on a little bit more!

@Rokt33r Rokt33r merged commit 3d958f4 into BoostIO:master Jan 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
guardrails/scan no new security issues detected
Details
@Rokt33r

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

@SubtleParesh I found it doesn't work well with snippet notes. Could you make another pr? I found the problem after I merged so I rolled back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.