Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError thrown on the Snippets page #2438

Merged
merged 1 commit into from Oct 11, 2018
Merged

Fix TypeError thrown on the Snippets page #2438

merged 1 commit into from Oct 11, 2018

Conversation

jacobherrington
Copy link
Contributor

This commit protects from a TypeError that is consistently
thrown on the Snippets page.

screen shot 2018-09-29 at 11 16 33 pm

This commit protects from a TypeError that is consistently
thrown on the Snippets page.
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Sep 30, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Sep 30, 2018

@jacobherrington How can I reproduce this error on the current master branch?

@jacobherrington
Copy link
Contributor Author

I get this on a fresh installation when I navigate to the Snippets tab. I'm on OS X.

@daiyam
Copy link
Contributor

daiyam commented Sep 30, 2018

@Rokt33r The error is here: screenshot

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 5, 2018
@Rokt33r Rokt33r added next release (v0.11.10) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Oct 11, 2018
@Rokt33r Rokt33r merged commit a9bad53 into BoostIO:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants