Fix toggle view breaking current document position #2606
Conversation
|
Is there something else I need to do before the review? |
|
No, it's just I'm a little bit busy. I'll try to review this as soon as possible. |
|
Can you fix the conflict? Thank you. |
Insecure Use of Regular Expressions (1)More info on how to fix Insecure Use of Regular Expressions in Javascript. Insecure Use of Language/Framework API (1)More info on how to fix Insecure Use of Language/Framework API in Javascript. Happy with the results? Give your feedback. |
|
I resolved the conflicts but I really don't understand what's going on with guardrails. Could you please advice me on what to do? The line it is referring to aren't a part of my pull request. |
|
Please ignore it, the bot is crazy:smile: |
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
I'm very sorry for the long wait 😢 Can you fix your code please?
|
|
||
| // "Remember" top line number (property of grand-parent component). | ||
| const currentLineAtTop = this.editor.lineAtHeight(this.editor.getScrollInfo().top, 'local') + 1 | ||
| this.props.topLine.number = currentLineAtTop |
There was a problem hiding this comment.
Modifying props is consider as anti-pattern for React. Can you do it some otherway? maybe notify parent to update instead of directly modifying like this
ZeroX-DG
added
awaiting changes 🖊️
|
@Erroler can you resolve the conflict and change your code please? If you not interested in this PR anymore, I'll take over this after a week |
Feel free to take over. |
2 participants
Fixes Issue #2563