Issue 2950 - clicking on elements when in full page preview toggles the mode back to split. #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master to fork
Fork update
|
I noticed that this file has quite a bit of CSS at the top. Is there reasons for it to be directly inside this file as opposed to a .styl file as all other files have in this folder? |
ZeroX-DG
added
approved 👍
Rokt33r
removed
the
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring of the handleMouseDown event such that the full page preview pane is not toggled off whenever any element -that is not the
<body>of the page- is clicked. Anything like a Button, Video, link etc should no longer toggle the view back to split.While I was at it, I cleaned up this function greatly, which should help the efforts of future developers.
Issue fixed
fix #2950
Type of changes
Checklist: