Fix regular expression related checkbox logic

[mpls104]

Description

As described in issue, checkbox was unclickable in quotation.
Fixed regular expression on checkbox logic and added some test patterns.

This is my first contribution to OSS in my life. 😄
Please kindly point out if there is something wrong 🙏

Issue fixed

#2829

Type of changes

• 🔘 Bug fix (Change that fixed an issue)
• ⚪ Breaking change (Change that can cause existing functionality to change)
• ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
• ⚪ Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔘 My code follows the project code style
• 🔘 I have written test for my code and it has been tested
• 🔘 All existing tests have been passed
• 🔘 I have attached a screenshot/video to visualize my change if possible

[ZeroX-DG]

I'm gonna be criticizing as hard as I can 🤣 Anyway, welcome to OSS

[ZeroX-DG]

It currently doesn't work for a nested quote like this. I don't know if we should support it.

[mpls104]

Thank you for checking precisely 😄
I think it's better to support this and done some changes.
What do you think @ZeroX-DG ?

[ZeroX-DG]

Well, I'll need confirmation from the "higher" power @Rokt33r

[AWolf81]

LGTM.

Just one thing I've noticed is that sub-elements are striked through if the top element is checked. I think you haven't introduced the issue but it's a bit weird and it would be probably better to not have them striked as they're not handled in the action item done count. See screenshot below, everything seems done but the counter says 60%.
But I think we could improve that in a separate PR if it's difficult to fix.

I'll have a look at your regex updates in a minute and leave an inline comment if there is something to improve.

[AWolf81]

I've first thought there are missing escape sequences in the regex but I think it's OK to omit them.
I did a quick test in the following regex101 - just wondering why the nested checkboxes are not matching there.
Is it because in Boostnote it is running in a loop or do I have a mistake in the regex101 test patterns?

[arcturus140]

it's a line pattern and only matched the first occurrence

[ZeroX-DG]

@AWolf81 The nested checkbox is strikethrough is because of the CSS property

text-decoration: line-through;

If that CSS property is applied to the parent element, the children element will be affected too which is a bit weird. You're right, it should be solved in a separated issue, it may be difficult to solve.

[arcturus140]

i think this strike through behaviour is intended, but I also think it is weird 😣

[Rokt33r]

LGTM. And I'm also thinking it is a bit weird. Let's fix it in other pr.