Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export to PDF exporting corrupted images #3068

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@KazumiHARADA
Copy link

commented Jun 9, 2019

Description

  • Apply the method of fixLocalURLS before exporting to pdf.

Issue fixed

#3033

Type of changes

  • 馃敇 Bug fix (Change that fixed an issue)
  • 鈿笍 Breaking change (Change that can cause existing functionality to change)
  • 鈿笍 Improvement (Change that improves the code. Maybe performance or development improvement)
  • 鈿笍 Feature (Change that adds new functionality)
  • 鈿笍 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 馃敇 My code follows the project code style
  • 鈿笍 I have written test for my code and it has been tested
  • 馃敇 All existing tests have been passed
  • 馃敇 I have attached a screenshot/video to visualize my change if possible

Screenshot:

test

Tested:

MacOS Mojave (10.14.5)

@ZeroX-DG
Copy link
Member

left a comment

LGTM 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.