Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HotkeyTab accidentally set incomplete hotkey, related #3190 #3194

Open
wants to merge 1 commit into
base: master
from

Conversation

@hikerpig
Copy link
Contributor

commented Aug 1, 2019

Description

Bug reason

Error is thrown in CodeEditor.js due to undefined hotkey input.

function translateHotkey (hotkey) {
  return hotkey.replace(/\s*\+\s*/g, '-').replace(/Command/g, 'Cmd').replace(/Control/g, 'Ctrl')
}

Solution

HotkeyTab should always emit complete hotkeymap.

Issue fixed

Type of changes

  • 馃敇 Bug fix (Change that fixed an issue)

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.