Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout #698

Merged
merged 4 commits into from Jul 10, 2017
Merged

Update layout #698

merged 4 commits into from Jul 10, 2017

Conversation

kazup01
Copy link
Member

@kazup01 kazup01 commented Jul 10, 2017

screen shot 0029-07-10 at 5 51 01 pm

screen shot 0029-07-10 at 5 51 12 pm

@kazup01 kazup01 requested a review from asmsuechan July 10, 2017 08:51
let { note } = this.state

let storageKey = note.storage
let folderKey = note.folder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use const instead of let.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done💯

})
})
})
let currentOption = options.filter((option) => option.storage.key === storageKey && option.folder.key === folderKey)[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use const instead of let.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doen🎶

Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 4f98d96 into master Jul 10, 2017
@kazup01 kazup01 deleted the update-layout branch July 10, 2017 15:21
@kohei-takata kohei-takata mentioned this pull request Jul 29, 2017
@kazup01 kazup01 mentioned this pull request Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants