-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the "Exact Matches Repair...." #157
Conversation
Looks like bike-mechanic and software developer go hand in hand? 😄 I will grab this build tomorrow. |
Flat tire, glue should be dry by now. Sure, enjoy your evening! |
Review: listFix_2.7.0-PR157-2
❓ Does it make sense to remove |
826dc32
to
f823de5
Compare
I also thing the "Find Exact Matches" does not make much sense. It does fix / replaces alternative broken entries with "exact" matched found. What about this?
I don't think I have made any changes in the code which explain the difference in performance. After running a Java application for a while, it may become faster, as the just-in-time (JIT) compiler kicks in. Parts of the code run frequently are optimized, which first causing some delay and next time it runs faster. Other effects on negative performance may be caused by anti-virus software, and thing running in the background like Windows updates. |
f823de5
to
cb550cc
Compare
In my opinion, merge and release. Drop all other forms of searching, or any of the renaming for it. Retain only "Select Closest Matches", as this is really all, and the only action, that really counts — it's the sole reason listFix() exists. "Select Closest Matches" is already extensive in function, and now nearly complete, and with a dialogue full of usable features to find the best matches. Later, the last piece to fit the accurate search puzzle, the search algorithm, can be reviewed. See also #154 |
Thank you @touwys for providing a clear focus. Okay, I will strip out the "exact match" everywhere. |
Stripped out exact repair. |
Looking good. Off-topic: consider if a command to cancel the |
Error found: when the app shortcut is pinned to the Windows Taskbar, it will display a blank icon, instead of the usual listFix logo-icon. |
Changes:
Resolves #154