Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #91

Merged
merged 1 commit into from Feb 11, 2020
Merged

Update README.md #91

merged 1 commit into from Feb 11, 2020

Conversation

@EwanRoycroft
Copy link
Contributor

EwanRoycroft commented Feb 11, 2020

Node throws "TypeError: MusicbrainzApi is not a constructor" when using the example in README.md. This is because MusicbrainzApi has a lower-case b and is undefined. It should be a capital B.

Node throws "TypeError: MusicbrainzApi is not a constructor" when using the example in README.md. This is because MusicbrainzApi has a lower-case b and is undefined. It should be a capital B.
@Borewit

This comment has been minimized.

Copy link
Owner

Borewit commented Feb 11, 2020

Thank you so much for correcting this @EwanRoycroft.

@Borewit Borewit merged commit 7bc4d50 into Borewit:master Feb 11, 2020
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
LGTM analysis: JavaScript No code changes detected
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DeepScan 0 new and 0 fixed issues
Details
@EwanRoycroft

This comment has been minimized.

Copy link
Contributor Author

EwanRoycroft commented Feb 11, 2020

@Borewit no problem! I haven't tested your typescript or configuration examples, but I notice they also have a lower-case b, so you may want to check this and update them as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.