link=false not working for {{if}} at all #74

Closed
athalay opened this Issue Jun 1, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@athalay

athalay commented Jun 1, 2012

I read that you advised to use link=false inside {{if}} conditions when they are inside a tag, because by default additional html-comments are generated around the if-condition-body.

I'm trying the following:

{{if level==1 link=false}} fikusz{{/if}}

But still html comments are generated around "fikusz". I want to use this approach to set/unset css-classes, but they don't work are simple content either.

What do I do wrong?

@BorisMoore

This comment has been minimized.

Show comment
Hide comment
@BorisMoore

BorisMoore Jun 6, 2012

Owner

You are correct. That is not currently working.

There have been some changes to how link and render interact, to ensure that if you call render, the annotations are never created. But with the new implementation, if you call link, the opting out of the link annotations within a specific tag such as {{if}} by setting link=false is not currently working, and needs to be re-implemented.

I will try to add that feature back in soon, and will update here when it is available. Thanks for calling this issue out.

Owner

BorisMoore commented Jun 6, 2012

You are correct. That is not currently working.

There have been some changes to how link and render interact, to ensure that if you call render, the annotations are never created. But with the new implementation, if you call link, the opting out of the link annotations within a specific tag such as {{if}} by setting link=false is not currently working, and needs to be re-implemented.

I will try to add that feature back in soon, and will update here when it is available. Thanks for calling this issue out.

@BorisMoore

This comment has been minimized.

Show comment
Hide comment
@BorisMoore

BorisMoore Jun 11, 2012

Owner

Fixed in a92f67f (Pre beta version 17)

Owner

BorisMoore commented Jun 11, 2012

Fixed in a92f67f (Pre beta version 17)

@BorisMoore BorisMoore closed this Jun 11, 2012

aredridel pushed a commit to blumenthals/RapidWeb that referenced this issue Jan 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment