New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spellcheck middleware added to JS repo #29
Spellcheck middleware added to JS repo #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and update the root README to add your package information, and update the CODEOWNERS file to add your package and your GitHub username. Then I think it's fine to merge.
@garypretty What's the general consensus on logging to the console or standard out? Should this be excluded from production packages to avoid additional noise/file consumption?
PR merged - done |
"dependencies": { | ||
"azure-cognitiveservices-spellcheck": "^1.0.1", | ||
"botbuilder": "^4.1.3", | ||
"ms-rest-azure": "^2.5.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are ms-rest-azure
and restify
dependencies for this library? I doesn't look like they are used in the middleware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test bot in the test folder is using restify. Could probably make this a dev dependency. My next package is going to implement the test adapter and mocha for tests, so we can use that as a template for unit tests moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of moving restify
do devDepencies, my advise would be to create a samples folder like the dotNet repo has. And keep the test folder purely for unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once I put in TestAdapter
unit testing along with mocha, we can follow that pattern for tests, and, yes, these test bots can then become samples.
Merge pull request #94 from szul/middleware
I added the spellcheck middleware based on Bing Spell Check similar to the text analytics middleware @szul added...