Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack prompt remains if figurine is removed before confirming request #68

Open
ryvaeus opened this Issue Jan 14, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@ryvaeus
Copy link

ryvaeus commented Jan 14, 2019

Describe the bug
When a player makes a request to attack another character/NPC, there is a slight delay before the GM sees the prompt to confirm or deny the request. During this delay, the GM might already be in the UI menu to delete the figurine. If the figurine is deleted before the prompt arrives, the GM never sees the prompt, yet the player will be stuck seeing the "You're trying to attack FOO" prompt until another request is made which will override the stuck one.

To Reproduce
Steps to reproduce the behavior:

  1. GM right-clicks NPC, preparing to kill it
  2. Player sends a request to attack NPC
  3. Immediately, GM kills NPC before the request comes in to his/her client

Screenshots/Videos/Twitch Clips
https://clips.twitch.tv/PiliableTolerantDotterelKeyboardCat

Additional context
Easily remedied by making another attack request

@cbaggers

This comment has been minimized.

Copy link
Contributor

cbaggers commented Feb 12, 2019

@ryvaeus You are a star. Thanks again for all these reports.

Can confirm this. Tracking internally Bouncyrock/TaleSpire#463

@cbaggers

This comment has been minimized.

Copy link
Contributor

cbaggers commented Feb 25, 2019

We have fixed this internally. Will be in next update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.