Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine server and static build configs #4

Merged
merged 1 commit into from Jan 19, 2015

Conversation

Projects
None yet
2 participants
@lettertwo
Copy link
Contributor

lettertwo commented Jan 19, 2015

As mentioned in your blog post on this project:

I am sure there is a way to just add this entry point to my node targeted “server” config in webpack.config.js…

snip

…If someone nows how to avoid this third config and still get dev/bundleStaticPage.js I’d love to hear from you.

If I understand what you want correctly, then this PR accomplishes just what you want!

Nice work!

BradDenver added a commit that referenced this pull request Jan 19, 2015

Merge pull request #4 from lettertwo/master
Combine server and static build configs

@BradDenver BradDenver merged commit bef2463 into BradDenver:master Jan 19, 2015

@BradDenver

This comment has been minimized.

Copy link
Owner

BradDenver commented Jan 19, 2015

Thanks very much for this pull request @lettertwo.

So the thing I had missed was that I had left my entry points as a flat array when they needed to be an object as the object keys set the [name] variable for the output files. I knew I was missing something obvious.

@lettertwo

This comment has been minimized.

Copy link
Contributor Author

lettertwo commented Jan 19, 2015

👍 perhaps it's not so obvious, when so many different values are valid (an array, a string, or an object of keys mapping to arrays or strings)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.