New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the YUV->RGB matrices #1415

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@jackwu95

jackwu95 commented Feb 12, 2014

Fixes the issue that causes GPUImage to render videos brighter than AVPlayer
The numbers are pulled directly from the diff of this change here: 2ad3e9c
Only changes the numbers, nothing else, tiny change

Revert the YUV->RGB matrices to the values
Fixes the issue that causes GPUImage to render videos brighter than AVPlayer
@tspecht

This comment has been minimized.

Show comment
Hide comment
@tspecht

tspecht Mar 4, 2014

Is this going to be merged any time soon? really bothers me that bug :(

tspecht commented Mar 4, 2014

Is this going to be merged any time soon? really bothers me that bug :(

@stelabouras

This comment has been minimized.

Show comment
Hide comment
@stelabouras

stelabouras Mar 16, 2014

Contributor

There is indeed a bug there but this is not the fix that does the trick. The tables for 601 and 709 have the proper values, but the bug is in the comparison of the color attachment value.

See my pull request here.

Contributor

stelabouras commented Mar 16, 2014

There is indeed a bug there but this is not the fix that does the trick. The tables for 601 and 709 have the proper values, but the bug is in the comparison of the color attachment value.

See my pull request here.

@BradLarson

This comment has been minimized.

Show comment
Hide comment
@BradLarson

BradLarson Mar 18, 2014

Owner

I went with the fix from pull request #1449 instead. Thanks for pointing this out, though, and sorry about the delay. I was working on a few other things.

Owner

BradLarson commented Mar 18, 2014

I went with the fix from pull request #1449 instead. Thanks for pointing this out, though, and sorry about the delay. I was working on a few other things.

@BradLarson BradLarson closed this Mar 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment