Skip to content

fix(docker): make service installation idempotent to avoid container … #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DJJones66 merged 1 commit into from
Oct 14, 2025
Merged

fix(docker): make service installation idempotent to avoid container … #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backend/app/plugins/service_installler/docker_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,16 @@ async def build_and_start_docker_service(
# Write environment file
write_env_file(target_dir, env_vars, required_vars)

# Clean up previous containers to avoid name conflicts
await _run_docker_compose_command("docker compose down --remove-orphans", target_dir)

# Rnu the docker compose build command
await _run_docker_compose_command(install_command, target_dir)

# Run the docker compose run command
# Start containers with force recreate
if "up" in start_command and "--force-recreate" not in start_command:
start_command += " --force-recreate"
await _run_docker_compose_command(start_command, target_dir)

# Wait for the service to become healthy
Expand Down