Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored slimConfiguration setting #23

Merged
merged 3 commits into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@JanMikes
Copy link
Contributor

JanMikes commented Dec 5, 2018

Fixes #22

@Achse
Copy link
Contributor

Achse left a comment

Hi, nice catch l, thanks for the fix :-) Will you please add test as well?

@JanMikes

This comment has been minimized.

Copy link
Contributor Author

JanMikes commented Dec 5, 2018

@Achse done 😉

Releasing it as 3.0.1 will be appreciated, for now i workarounded it with this composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/JanMikes/slim-nette-extension"
        }
    ],
   "require: {
      "brandembassy/slim-nette-extension": "dev-fix-ignored-slimConfiguration"
  }
@Achse

Achse approved these changes Dec 7, 2018

@Achse Achse merged commit 62bbb25 into BrandEmbassy:master Dec 7, 2018

@Achse

This comment has been minimized.

Copy link
Contributor

Achse commented Dec 7, 2018

JanMikes added a commit to JanMikes/Caloriary that referenced this pull request Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.