Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Global app middlewares and multiple action methods"" #9

Merged
merged 2 commits into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@Achse
Copy link
Contributor

Achse commented Mar 20, 2018

Reverts #8

@Achse Achse requested review from michalbrauner and dominikvoda Mar 20, 2018

@Achse

This comment has been minimized.

Copy link
Contributor Author

Achse commented Mar 20, 2018

@dominikvoda sorry, here is revert of revert

README.md Outdated
globalMiddlewares:
- App\SomeGlobalMiddleware # this is called for each route, before route middlewares

This comment has been minimized.

@Achse

Achse Mar 20, 2018

Author Contributor

Tabs instead of spaces.

Achse referenced this pull request Mar 20, 2018

@JanMikes
Copy link
Contributor

JanMikes left a comment

I am a bit confused what is the difference between globalMiddlewares and appMiddlewares config options

@Achse Achse force-pushed the revert-8-revert-5-global-middlewares-and-multiple-methods branch 4 times, most recently from f04a626 to 9dd4f79 Oct 1, 2018

public function __invoke(RequestInterface $request, ResponseInterface $response, callable $next)
{
$response = $response->withAddedHeader(
'processed-by-app-before-request-middleware',

This comment has been minimized.

@janveselynet

janveselynet Oct 1, 2018

Nema byt tohle spis processed-by-before-request-middleware?

@Achse Achse force-pushed the revert-8-revert-5-global-middlewares-and-multiple-methods branch from 9dd4f79 to 03fd245 Oct 1, 2018

@Achse Achse merged commit 1053e17 into master Oct 1, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Achse Achse deleted the revert-8-revert-5-global-middlewares-and-multiple-methods branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.