Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Additional space after comments #11

Closed
danieltomasz opened this issue Mar 12, 2021 · 12 comments
Closed

[BUG] Additional space after comments #11

danieltomasz opened this issue Mar 12, 2021 · 12 comments
Assignees
Labels

Comments

@danieltomasz
Copy link

@danieltomasz danieltomasz commented Mar 12, 2021

Describe the bug
A clear and concise description of what the bug is.

Spectrum theme render additional space after line with comments
To Reproduce

Code here

## Today tasks
%%Put the stuff here%%
- 7PM Week review

produces in default Obsidian
image

With spectrum theme
image

Expected behavior
A clear and concise description of what you expected to happen.

Spectrum theme will not render comments as empty line
image

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS] MacOS BigSur
  • Obsidian Version: [e.g. 22] 0.11.5

Additional context
Add any other context about the problem here.

@Braweria
Copy link
Owner

@Braweria Braweria commented Mar 12, 2021

Oh wow, that is weird. 🤔
I will take a look into it, thanks for letting me know.

@Braweria Braweria self-assigned this Mar 12, 2021
@Braweria
Copy link
Owner

@Braweria Braweria commented Mar 12, 2021

I looked into it, and I get the same break with default as well as with Spectrum. When using a comment, it creates an additional <br> element, which causes the empty line.

I will have to talk with other people about it and see if they found a solution. 🤔 It might be because of flexbox, but I can't really tell at the moment.

@DannyDies
Copy link

@DannyDies DannyDies commented Jun 1, 2021

Hello👋 The same thing happens with line reference.
ref

@Braweria
Copy link
Owner

@Braweria Braweria commented Jun 4, 2021

@DannyDies Very curious, have you tested it with the vanilla theme as well?

@DannyDies
Copy link

@DannyDies DannyDies commented Jun 4, 2021

In default and other themes works fine. Disable all snippets too. Seems like a flexbox problem(other themes I've tested haven't it)

@DannyDies
Copy link

@DannyDies DannyDies commented Jun 5, 2021

p.s. it also render this reference too big.
image
vs
image

@DannyDies
Copy link

@DannyDies DannyDies commented Jun 6, 2021

In my case, I disabled .markdown-preview-view.is-readable-line-width .markdown-preview-sizer. Then all stuff align to the left, so I disabled all css from 2 section(Text area) and all just fine for my issue. Flex features not important for me right now. But if you solve it another way, please, let me know.

@Braweria
Copy link
Owner

@Braweria Braweria commented Jun 8, 2021

thanks for the additional info. i will try to find time this week for it.

@Braweria
Copy link
Owner

@Braweria Braweria commented Jun 28, 2021

Obsidian adds an empty div and p container when you have a reference.

<div>
  <p>a test note </p>
  <div></div>
  <p></p>
</div>

is what it outputs when you write

a test note ^reference

But if you do not have a reference, then obsidian outputs this instead, which is how it should be:

<div>
  <p>a test note </p>
</div>

@DannyDies
Copy link

@DannyDies DannyDies commented Jun 28, 2021

@Braweria i tried to adjust that property. It makes effect. But I'm so tired to think tonight. Can it help?

.markdown-preview-view div p{
  margin-bottom: 0rem;
}

@Braweria
Copy link
Owner

@Braweria Braweria commented Jun 28, 2021

@DannyDies I have discussed that issue with people on the Discord Server and made a bug report on the Forum, with version 0.12.9 this will be fixed.

@DannyDies
Copy link

@DannyDies DannyDies commented Jun 28, 2021

Oh, it nice. Thanks for your efforts! Waiting 12.9.

@Braweria Braweria closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants