You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, PySceneDetect uses the root logger with a basic configuration. It should be replaced with an explicitly named logger instead to avoid conflicts with other projects using scenedetect as a dependency.
Furthermore, some objects/functions take explicit logger objects as an argument. Modify them to use the named logger instead.
Lastly, ensure that when the package is imported, the named logger is instantiated immediately but with the highest warning level. Only override it when instantiating the CLI.
The text was updated successfully, but these errors were encountered:
This only needs to be done for non-CLI parts of the library fortunately, which currently the only things that log messages are scene_manager.py, stats_manager.py, and video_splitter.py. This also indicates that better logging could be implemented throughout the library rather than only for the CLI, but that can be an improvement made in the v1.0 refactor.
Currently, PySceneDetect uses the root logger with a basic configuration. It should be replaced with an explicitly named logger instead to avoid conflicts with other projects using
scenedetect
as a dependency.Furthermore, some objects/functions take explicit logger objects as an argument. Modify them to use the named logger instead.
Lastly, ensure that when the package is imported, the named logger is instantiated immediately but with the highest warning level. Only override it when instantiating the CLI.
The text was updated successfully, but these errors were encountered: