New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color histogram method #53

Open
r1b opened this Issue May 7, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@r1b

r1b commented May 7, 2018

I noticed that you have a stub for a HistogramDetector. I have completed a proof-of-concept using this method in this notebook.

Do you think this is a sound approach? I don't have a lot of experience with this kind of problem so I am curious to hear your thoughts. I would love to integrate this into pyscenedetect.

@Breakthrough

This comment has been minimized.

Owner

Breakthrough commented May 8, 2018

Very interesting approach. Have you given some thought to benchmarking it versus Albanie's shot detection benchmarks to see how it performs?

It would be quite interesting to have some additional detection techniques in PySceneDetect for sure. I haven't had much time to keep up with the project lately, but I'm always open to pull requests!

@Breakthrough

This comment has been minimized.

Owner

Breakthrough commented Jul 23, 2018

Also @r1b, this definitely does seem to be a sound approach - there is plenty of literature referencing this method.

I will have to do some more research into your work, but definitely plan to get started on something like this in the future. I have added this to the backlog of issues, indicating it will be worked on for the next major release of PySceneDetect following v0.5 (the project is almost done a heavy refactor which should make developing detectors much easier).

Also just curious, what is your development environment like? I'm not too familiar with Python notebooks, but some of the analysis (esp. with regards to the graphs) would be immensely useful. Just curious what you're using, if it's an interactive environment.

@r1b

This comment has been minimized.

r1b commented Jul 24, 2018

Wonderful! When I have some free time I will play with it some more. I am using Jupyter as a development environment to take advantage of the inline plotting & exploratory workflow. Usually I use matplotlib for plots but here I use Seaborn mostly just to use distplot (but I also think they look nicer).

@Breakthrough

This comment has been minimized.

Owner

Breakthrough commented Jul 28, 2018

Thank you for the references @r1b , will definitely be checking out Jupyter. Thank you also for the proof of concept, had some time to look into it briefly and will be following up on this after v0.5 is released. One thing I'm experimenting with is automatic threshold detection for the content/threshold detectors, and had a few high-level questions if you don't mind me picking your brain.


I noticed in your notebook that you're using the equation for threshold T = μ + ασ, where μ is the mean, σ is the standard deviation, and α is a constant set to 5.

Just curious, how did you arrive at a value of α = 5? Does it need to be adjusted for different types of source material?


For the histogram itself, have you experimented at all with changing the number of frequency bins in the histograms, or generating the colour code in HSV space instead of RGB? Just trying to flesh out the design by trying to get a feel for what options need to be presented to the user when calling detect-histogram, and what the exact equations/algorithms need to be in place.

I'm trying to use the same equation to automatically generate T for the ContentDetector algorithm, but I can't seem to find a good value for α that works across a good number of source material - specifically when dealing with shorter clips. I was also wondering if you had any ideas for approaching computing a good value for α (or if another equation would be better in this case) for the ContentDetector, which computes a single HSV-based frame score.

Also, feel to check out the upcoming API if you have a minute, any feedback you might have is most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment