Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling Save Images from Python Interface #88

Closed
KevinJ90825 opened this issue Jan 7, 2019 · 6 comments
Closed

Calling Save Images from Python Interface #88

KevinJ90825 opened this issue Jan 7, 2019 · 6 comments
Labels
Milestone

Comments

@KevinJ90825
Copy link

KevinJ90825 commented Jan 7, 2019

Description of Problem & Solution
I would like to be able to generate images for split scenes with the Python API, in the same way you can generate them with the CLI save-images command

Proposed Implementation:
The addition of an API method in the video-splitting module, ideally, or wherever else might be deemed appropriate.

@Breakthrough

This comment has been minimized.

@Breakthrough Breakthrough modified the milestones: v0.6, v0.5.2 Sep 20, 2019
Breakthrough added a commit that referenced this issue Sep 20, 2019
…t path getter into platform module as get_and_create_path. TODO: Remove _generate_images from cli.context. Issue: #88

Remove trailing whitespace on modified files.

Update documentation to reflect better what needs to still be done before #88 can be closed.
@Breakthrough
Copy link
Owner

Breakthrough commented Sep 20, 2019

Implemented global function scenedetect.scene_manager.generate_images in v0.5.2-dev, and still TODO is to add an actual save_images method to the SceneManager which will invoke the generate_images function.

@Breakthrough
Copy link
Owner

Breakthrough commented Nov 9, 2019

This function will need to be modified either as part of #123 / #125 or another changeset afterwards. If #123 / #125 have to be deferred to v0.6 because they require breaking API changes, this will be implemented first in v0.5.2 (as it is a non-breaking API change).

@Breakthrough
Copy link
Owner

After #129 is merged, work on this will resume, which also needs to write unit tests for the new global function.

@Breakthrough
Copy link
Owner

Breakthrough commented Jan 11, 2021

This is now available in the v0.5.5 branch. It can be called via scenedetect.scene_manager.save_images now. Targeting v0.5.5 release now.

TODO:

  • finish documentation, add to manual [done (link)]
  • add unit tests [done]
  • update changelog [done]

@Breakthrough Breakthrough modified the milestones: v0.6, v0.5.5 Jan 11, 2021
@Breakthrough
Copy link
Owner

This has been included in the v0.5.5 release. Documentation for the save_images() function can be found here (link).

@Breakthrough Breakthrough unpinned this issue May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants