Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip retaining the last frame if images are not saved #40

Merged
merged 1 commit into from Sep 5, 2017

Conversation

@elcombato
Copy link
Contributor

commented Jul 19, 2017

If images at scene cuts are not saved, copying of the last frame is skipped.
I recorded savings in runtime of detect_scenes() with scene_manager.save_images=False between 6% and 11%.

@Breakthrough

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2017

Thanks for this PR, I'll definitely merge this into the next release of PySceneDetect. I'm working on some major API changes at the moment, so will delay accepting this until then (just want to make sure I can reliably test the changes).

That being said, I don't see any changes to the API that will require any changes to this PR, so I should be able to merge it as-is. Will let you know when I've merged and tested this, but like I said, it will definitely make the upcoming release (v0.5), so should be soon hopefully.

Thanks again for taking the time to help improve PySceneDetect.

Edit: I realized this has no conflicts with the local changes I've been testing, and thus merged it now. Note that the area where the code change was made will be moved to the manager.py file for the next release, but indeed this is a very useful PR to reduce unnecessary memory copy operations.

@Breakthrough Breakthrough merged commit 3c2341a into Breakthrough:master Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.