New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False alarm "x backups done on drive y:\ in the last two weeks, where database files also live. This represents a serious risk if that array fails." #1916

Closed
HenrikStaunPoulsen opened this Issue Jan 9, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@HenrikStaunPoulsen
Copy link

HenrikStaunPoulsen commented Jan 9, 2019

Version of the script
7.1 dated 20190101

What is the current behavior?
if reports
x backups done on drive y:\ in the last two weeks, where database files also live. This represents a serious risk if that array fails."
even if there are no databases on the y: drive EXCEPT TempDb

If the current behavior is a bug, please provide the steps to reproduce.
put tempdb on its own drive. backup a database to the same drive. run sp_blitz.

What is the expected behavior?
tempdb is recreated on start-up, so we're not loosing data if we lose that drive.

Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?
all versions, event SQL Server 2008 R2.

Note:
I'll try to change line 958 of sp_blitz from
FROM sys.master_files AS mf )
to
FROM sys.master_files AS mf WHERE mf.database_id <> 2)

which fixes the problem on my server.
I'm not a GitHub super-user, so it may take a day or two.

BrentOzar added a commit that referenced this issue Jan 9, 2019

BrentOzar added a commit that referenced this issue Jan 9, 2019

Merge pull request #1917 from BrentOzarULTD/1916_sp_Blitz_tempdb_back…
…up_location

#1916 sp_Blitz ignore backup on TempDB drive
@BrentOzar

This comment has been minimized.

Copy link
Member

BrentOzar commented Jan 9, 2019

Great catch, and great bug report! You made the fix really easy, so I went ahead and did it. It's in the dev branch now, and it'll be in the next release. Thanks sir!

@BrentOzar BrentOzar self-assigned this Jan 9, 2019

@HenrikStaunPoulsen

This comment has been minimized.

Copy link
Author

HenrikStaunPoulsen commented Jan 10, 2019

great, then I did not have to learn to use GitHub, again.

BrentOzar added a commit that referenced this issue Jan 28, 2019

2019-01 Release (#1932)
* Updating readme.md for sp_DatabaseRestore

Documenting @ExistingDBAction for https://dba.stackexchange.com/questions/226145/sp-databaserestore-msg-50000.

* 1900 sp_BlitzIndex add histograms

When @TableName is specified and sys.dm_db_stats_histogram is available. Closes #1900.

* #1903 sp_Blitz SQLServerCheckup

Adding filter for that app name. Closes #1903.

* #1905 sp_BlitzIndex remove BOU link

Nothing against BOU, just don't need it in that particular place. Closes #1905.

* #1908 Update copyright dates

Ah, the glamour. Closes #1908.

* Issue #1904 Change RAISERROR 'severity' for that should trigger throw and error.

* Issue #1910 Add SQL Server version check before choosing 'memory grant' as the @BlitzCacheSortOrder.

* Issue #1910 Add temp table creation.

* #1914 sp_BlitzIndex partition error severity

Dropping severity level from 16 to 0 since we're logging it in the result set anyway. Closes #1914.

* Issue 1894 Moved RESTORE HEADERONLY up

* LF line endings

* added some extra checks + corrected some nesting

* rebase and line endings

* Web site commit

Does this fix line endings?

* #1916 sp_Blitz ignore backup on TempDB drive

Closes #1916.

* Auto line endings

Dealing with sp_DatabaseRestore's line endings.

* 1919 sp_Blitz ignoring a few checks for Managed Instances (#1920)

* 1919 sp_Blitz ignoring a few checks for Managed Instances

Working on #1919.

* #1919 sp_Blitz excluding restored databases

When checking backup history. Working on #1919.

* #1919 sp_Blitz ignore some checks on Mgd Instances

Changing RCSI wording on Azure SQL DB. Working on #1919.

* #1921 Sp_BlitzIndex Add Drop and Create Columns to Output (#1923)

Joined output query to #IndexCreateTsql to retrieve the CreateTsql already generated earlier in the script.  Created Drop TSQL based off evaluating what type of index was present.

* #1921 sp_BlitzIndex adding drops (#1924)

Moving drop and create TSQL to the end of mode 2's results. Closes #1921.

* #1925 sp_Blitz AWS RDS detection (#1926)

Don't just rely on EC2 VM name to detect RDS. Also adds a new result noting that checks were skipped. Closes #1925.

* #1927 sp_BlitzIndex skip rdsadmin db (#1928)

GetAllDatabases = 1 fails when it hits rdsadmin because they're referring to the resource db. Closes #1927.

* 2019_01 Release (#1931)

Prep work for the release - changing version numbers, building build scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment