Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_BlitzIndex: merge low-impact and high-impact missing indexes #1991

Closed
BrentOzar opened this Issue Mar 5, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@BrentOzar
Copy link
Member

BrentOzar commented Mar 5, 2019

We have two findings:

  • "Indexaphobia: High value missing index with Low Impact"
  • "Indexaphobia: High value missing index with High Impact"

Let's just merge these together into:

  • "Indexaphobia: High value missing index"

@BrentOzar BrentOzar added this to the 2019-03 milestone Mar 5, 2019

@BrentOzar BrentOzar self-assigned this Mar 5, 2019

BrentOzar added a commit that referenced this issue Mar 20, 2019

#1991 sp_BlitzIndex simplify missing indexes
Skips the high/low benefit stuff. Closes #1991.

BrentOzar added a commit that referenced this issue Mar 20, 2019

#1991 sp_BlitzIndex simplify missing indexes (#2002)
Skips the high/low benefit stuff. Closes #1991.
@beckmanjm

This comment has been minimized.

Copy link

beckmanjm commented Mar 21, 2019

This is an unfortunate change - we preferred the old way of doing things. For the most part, the Low Impact indexes were ones we ignored, but might look at if there were also high impact indexes. We break them out in reports. Any way this could be made optional?

@BrentOzar

This comment has been minimized.

Copy link
Member Author

BrentOzar commented Mar 21, 2019

The problem is that the impact is SQL Server's guess, and that guess was often wrong. It might estimate that an index have low impact, but then the presence of the index radically changes the plan, and further opportunities arise. I just wouldn't put any credence in that number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.