Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_DatabaseRestore t-log restores not applied when @BackupPathFull is null #2036

Closed
troyjennings opened this issue Apr 24, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@troyjennings
Copy link
Contributor

commented Apr 24, 2019

Version of the script
@Version = '7.4', @VersionDate = '20190320'

What is the current behavior?

When @BackupPathFull is null, @BackupPathLog is set and @ContinueLogs = 1, no transaction log backups are applied.

What is the expected behavior?

Transaction log backups should be applied when the database is already in recovery and only the path to the log backups is provided.

@troyjennings troyjennings changed the title sp_DatabaseRestore t-log restores not appled when @BackupPath is null sp_DatabaseRestore t-log restores not applied when @BackupPathFull is null Apr 24, 2019

@BrentOzar

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

OK, cool. Do you want to make the changes? (I don't personally use this script these days, so I don't have a testing environment for it.) You can check out the contributing guide for more info on how to do it, or check in with the Slack channel in there to see if someone else may be able to help you do it.

@reharmsen

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

I did notice this in February or March, hence we reverted to an older version we were running and which functions for us (6.9 / 20180901). Did not find time yet to dive in to this further.

If @troyjennings is not able to look into this, I might try to find some time in May to look in to this and hopefully fix this in the most recent version, at least for our setup.

@troyjennings

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@reharmsen I have a fix for it that I was testing over the weekend. I plan on pushing it today.

@reharmsen

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@troyjennings If you need help reviewing or testing I am glad to help

@troyjennings

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

@BrentOzar

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Merged the fix - thanks @troyjennings! Will be in the May release and credit you.

@BrentOzar BrentOzar closed this May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.