Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sp_executeSQL" in Uninstall.sql needs to be "sp_executesql" for case-sensitive collations. #2307

Closed
Protiguous opened this issue Feb 19, 2020 · 1 comment
Assignees
Labels
bug

Comments

@Protiguous
Copy link

@Protiguous Protiguous commented Feb 19, 2020

First Responder Kit Uninstaller Script "Uninstall.sql" as of 2020-19-02.

The letters SQL are capitalized in the command "EXEC sp_executeSQL @innerSQL, N'@Sql nvarchar(max) OUTPUT', @Sql = @Sql OUTPUT;".

This will fail to execute on case-sensitive collations, "sp_executeSQL" needs to be "sp_executesql".

@BrentOzar BrentOzar self-assigned this Feb 21, 2020
@BrentOzar BrentOzar added the bug label Feb 21, 2020
@BrentOzar BrentOzar added this to the 2020-03 Release milestone Feb 21, 2020
BrentOzar added a commit that referenced this issue Feb 21, 2020
Now works on case-sensitive collations. Closes #2307.
BrentOzar added a commit that referenced this issue Feb 21, 2020
…tive

#2307 uninstall case sensitive
@BrentOzar

This comment has been minimized.

Copy link
Member

@BrentOzar BrentOzar commented Feb 21, 2020

Thanks for the heads up. Fixed in the dev branch, and it'll be in the March release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.