New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive on NC PKs #1884

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
1 participant
@BlitzErik
Copy link
Contributor

BlitzErik commented Dec 11, 2018

Closes #1883

Changes proposed in this pull request:

  • Fix false positives on NC/PK

How to test this code:

CREATE TABLE dbo.HeapsOfSadness (Id1 INT IDENTITY(1,1), CustomeRID INT, Stuffing CHAR(1000),
CONSTRAINT PK_Id1 PRIMARY KEY NONCLUSTERED ([Id1] ASC));
GO
--CREATE CLUSTERED INDEX [CLIX_CustomeRID] ON [dbo].HeapsOfSadness (CustomeRID);
GO
INSERT INTO dbo.HeapsOfSadness (CustomeRID, Stuffing)
  SELECT 1, 'Stuff' /* Short */
  FROM sys.messages;
GO

Toggle creating the CX.

Has been tested on (remove any that don't apply):

  • Case-sensitive SQL Server instance
  • SQL Server 2016
  • SQL Server 2017

@BlitzErik BlitzErik added this to the Have you seen me lately? milestone Dec 11, 2018

@BlitzErik BlitzErik self-assigned this Dec 11, 2018

@BlitzErik BlitzErik merged commit e1d050c into dev Dec 11, 2018

@BlitzErik BlitzErik deleted the issue_1883 branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment