Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display widget graph while editing settings #410

Open
steersbob opened this issue Feb 20, 2019 · 3 comments

Comments

@steersbob
Copy link
Member

commented Feb 20, 2019

No description provided.

@j616

This comment has been minimized.

Copy link

commented Feb 20, 2019

Suggestion for a possible design pattern for this. Widgets tend to have two types of windows/popovers that may be opened. One is the configuration popover and one is the graph view. These are both parts of a single widget. It may make sense from a user perspective if they were part of the same window. A user clicks on a button on the widget to get a "detailed view" window. This window could contain tabs that are quick to move between when viewed on smaller devices or a side-by-side view on larger devices. Both tabs and side-by-side will allow users to easily view both the graphs and configurable settings on a PID for example.

@steersbob

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

It'd require some reshuffling of where elements live in code, but the general idea seems workable.

  • mobile: always tabbed
  • desktop: default tabbed, choose between tabbed and split-screen view

@steersbob steersbob added this to Accepted in BrewBlox Mar 27, 2019

@steersbob steersbob moved this from Accepted to In progress in BrewBlox May 14, 2019

@ghost ghost assigned steersbob May 15, 2019

@ghost ghost added review and removed backlog labels May 15, 2019

@steersbob steersbob moved this from In progress to Accepted in BrewBlox May 15, 2019

@steersbob

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

Graph and SetpointProfile now have a preview graph. We'll tinker with them a bit before deciding on whether we want to implement it for all widgets with graph data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.