New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple dialogs when cancelling an action for more than one Item in the tree #25

Closed
rocketman768 opened this Issue Apr 18, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@rocketman768
Copy link
Member

rocketman768 commented Apr 18, 2015

From launchpad #1445671

When selecting more than one Item in the tree (i.e. recipes) and choose
'copy' from the context-menue, a dialog appears which asks for a name
for each copy. If you decide to abort copying you have to cancel this
dialog for every previously selectet item. Maybe it would be nice if
hitting "cancel" once aborts all of the following copy-processes.

Brewtarget 2.1.0 on MacOS 10.10.3

@rocketman768 rocketman768 added this to the v2.2.0 milestone Apr 18, 2015

@mikfire

This comment has been minimized.

Copy link
Contributor

mikfire commented Apr 18, 2015

How do I assign this ticket to myself?

@rocketman768

This comment has been minimized.

Copy link
Member

rocketman768 commented Apr 18, 2015

Directly to the right of the original comment, there is a column with "Labels," "Milestone," and "Assignee" sections. Click on assignee and you should see your id.

@mikfire

This comment has been minimized.

Copy link
Contributor

mikfire commented Apr 18, 2015

The "click on assignee" doesn't work. As in, that isn't something I can click.

@rocketman768

This comment has been minimized.

Copy link
Member

rocketman768 commented Apr 18, 2015

Hm. Let me see if there is some setting I have to change.

mikfire pushed a commit to mikfire/brewtarget that referenced this issue Apr 22, 2015

Mik Firestone
Closes feature request Brewtarget#25 -- multiple dialogs
This closes feature request Brewtarget#25 -- multiple dialogs when canceling a copy. I
rearranged things so that the code in MainWindow is much cleaner; there are no
more copyThis() methods. Instead I drove all the complexity into BtTreeView
and BtTreeModel, like deleteSelected.

This does somewhat change the syntax of the cancel button. To avoid copying a
single item, just enter an empty name. I added a tool type to explain this. I
also changed the "Cancel" button to read "Cancel All", hoping this will make
it more obvious.
@mikfire

This comment has been minimized.

Copy link
Contributor

mikfire commented Apr 22, 2015

Oh. I like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment